This repository has been archived by the owner on Apr 22, 2021. It is now read-only.
Removing unused imports. #304
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrected and clarified the 'MISSING RENDER' error case.
When passed as inline parameters, memory is expressed as MB. However, when passed in a config file, memory was expressed as KB. This created confusion https://discordapp.com/channels/253355867938750485/301912419368697856/541719192252973066 https://discordapp.com/channels/253355867938750485/301912419368697856/541719244094701597 https://discordapp.com/channels/253355867938750485/301912419368697856/541719343684124696
Make config file loader take ram in MB for consistency
clarification of error message
Fix Ant Build
… allow by scheduler depending on the past error, current settings (ram, cpu, gpu,...)
Fix grammar and consistency of README
… anymore, it should be removed
…et#256) * Fix: -renderbucket-size option not applied if configuration file doesn't exist
* Include public key as password in help
* Fix failed MimeType detection * Fix failed MimeType detection * Fix formatting
…tain time (laurent-clouet#249) A new -shutdown <time> option has been created to specify the time when the client will stop asking for new jobs, will finish uploading the frames in the upload queue and will shutdown the computer. The time argument can have two different formats: an absolute date & time in the format yyyy-MM-ddThh:mm:ss (24h format) or a relative time in the format +m where m is the number of minutes from now. The user can also select the shutdown-mode, where "wait" will wait for all the processes (render + pending uploads) to finish and "hard" will cancel all the pending jobs and will initiate the computer shutdown.
…t#282) * restore missing time remaining time in UI with openCL
…urent-clouet#287) * Feature: add session data consumption information in GUI/text UIs Adds the total bytes downloaded and uploaded in the current session as well as the average data transfer rate for both UL/DL. The information is not added to the 1-line UI as the line will take 150+ characters in the screen.
Isolating classes from giving too much access to private properties (removing @DaTa). Removing unused visibility options from interface. Moving some classes to specific packages.
|
When PRing such a large batch of changes, usually you'd provide a reason (even if you think the reason is obvious). Also, it is better to create 4 PRs for 4 changes, not 1 massive Code Cleanup PR. Finally, please adjust your title, it's misleading. |
|
I were able to build the client and run it. So it could be fine. |
laurent-clouet
force-pushed
the
master
branch
2 times, most recently
from
90c3325 to
7f1949e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Isolating classes from giving too much access to private properties (removing @DaTa).
Removing unused visibility options from interface.
Moving some classes to specific packages.